Add HasCallStack to partial functions

haskell / containers

Assorted concrete container types

https://hackage.haskell.org/package/containers

315 stars 177 forks source link

Add HasCallStack to partial functions #489

Open dwincort opened 6 years ago

dwincort commented 6 years ago

Can we add HasCallStack to the constraints of partial functions like Map.!? I'd be happy to put together a PR if it's a change that would get accepted.

treeowl commented 6 years ago

Yes, please! I was already thinking about doing that. But please show benchmark results to make sure the performance impact is tolerable.

On Jan 11, 2018 12:37 PM, "Daniel Winograd-Cort" notifications@github.com wrote:

Can we add HasCallStack to the constraints of partial functions like Map.!? I'd be happy to put together a PR if it's a change that would get accepted.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haskell/containers/issues/489, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzi_XyCCjFQHVVCFlk7idclZNrHCL83ks5tJkbNgaJpZM4RbMQ8 .

sjakobi commented 4 years ago

Since the analogous work on unordered-containers was very warmly received, I'd love to see progress on this issue.

AFAICT not all changes in #493 are problematic. I think it might be a good first step to extract those into a separate PR that can be merged quickly.

(CC @bollu)

dwincort commented 4 years ago

Oh wow, I totally forgot about this. The project I was working on ended up finding a different way to track errors, and this went to the bottom of my priority list.

I don't have the bandwidth right now to work on this, so if someone else wants to take over, that would be great. Otherwise, I may be able to find some time in a few weeks. I'll make a reminder for myself.

sjakobi commented 4 years ago

For reference: Similar plans for base are discussed in https://gitlab.haskell.org/ghc/ghc/-/issues/17040.