Open sidkshatriya opened 1 year ago
@m-renaud is definitely more qualified to answer this then I am, or probably anyone else. I know literally nothing about that submodule.
For background: haddock-autolink is only used in the generation of the Markdown docs which live at https://haskell-containers.readthedocs.io/en/latest/ (but is also used by other doc sets outside of container).
To your questions: the code is very simple, so if desired could be inlined into containers, or hoisted to the haskell GitHub organization.
@m-renaud It sounds like the most urgent matter is for you to add a suitable license for haddock-autolink
. Would you be able to do that soon? Beyond that, I'm going to continue to hide under my rock and let you maintain that side of things.
@treeowl sorry for the delay! PTAL at https://github.com/m-renaud/haddock-autolink/pull/2 (BSD 3-Clause which to my understanding is compatible).
@m-renaud What does PTAL mean? Can you submit a commit to get the license in the submodule?
PTAL means "Please take another look" IIUC (if I understand correctly).
BTW the PR is not merged yet.
While cloning the main ghc repository (using
git clone https://gitlab.haskell.org/ghc/ghc.git --recurse-submodules
) I noticed that thecontainers
repository was being cloned. That's OK because thecontainers
library is a submodule of the ghc repo.However, I noticed that the
haddock-autolink
submodule ofcontainers
is also being cloned. This is becausehaddock-autolink
is a submodule of thecontainers
repo.( https://github.com/haskell/containers/blob/b216597c83755131aac0f335744e2f803eaa9399/.gitmodules )
Here is what I noticed:
containers
require a license given thatghc
usescontainers
which in turn useshaddock-autolink
?haddock-autolink
seems to be a notable exception. Might it be a good idea to incorporate this submodule into thecontainers
repo itself? (especially because it is a small one). Ideally all the source dependencies of ghc should be more firmly in its control so we don't need to worry about the long term availability/maintenance of thehaddock-autolink
repo which is under control of a different entity than ghc presumably.Request maintainers of
containers
suggest if any of these two issues need to be addressed.cc: @m-renaud