haskell / containers

Assorted concrete container types
https://hackage.haskell.org/package/containers
314 stars 177 forks source link

Unnecessary CPP and C header in `Data.Map.Internal.Debug.html`? #968

Open Vlix opened 10 months ago

Vlix commented 10 months ago

I see containers.h being #included in almost every module, which is probably the point, but is this just a specific choice: "include it everywhere, if we ever need it it'll be in scope and if we don't the compiler will just ignore it"? Or is this an oversight and is it better to limit the amount of CPP pragmas and inclusion of C headers?

Asking in case someone (me?) might want to clean it up, or that this is intentional and should stay this way.