Silence deprecation warnings for Data.Semigroup.Option

haskell / deepseq

Deep evaluation of data structures

http://hackage.haskell.org/package/deepseq

Other

40 stars 29 forks source link

Silence deprecation warnings for Data.Semigroup.Option #55

Closed sjakobi closed 4 years ago

sjakobi commented 4 years ago

Corresponding GHC MR: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3388

sjakobi commented 4 years ago

@chessai Would you mind just optimistically merging this one, so I could test the GHC MR in CI? If the MR doesn't end up getting accepted for some reason I can revert this patch.

bgamari commented 4 years ago

@sjakobi, for the recor, for the purposes of testing via CI you can also push the branch to the GitLab mirror as a branch under the wip/ namespace.

sjakobi commented 4 years ago

@bgamari Yes, that would have been the better thing to do! :/

This PR unfortunately doesn't validate with the current GHC HEAD (8.11...), so I have now pushed a fix to the GitLab mirror: https://gitlab.haskell.org/ghc/packages/deepseq/-/commit/0ade68f6f54d621132e9bb5f9e3c5fe01f45091f

Apologies!