search

haskell / deepseq

Deep evaluation of data structures
http://hackage.haskell.org/package/deepseq
Other
40 stars 29 forks source link

Fix GHC version bound in CPP #57

Closed sjakobi closed 4 years ago

sjakobi commented 4 years ago

Context: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3388

chessai commented 4 years ago

We shouldn't have CPP referring to unstable branches of GHC in the source. So you should do the thing Ben mentioned in the other PR.

sjakobi commented 4 years ago

Well, since the current HEAD version is still 8.11.…, my GHC MR can't validate without this patch. I have indeed pushed it to the GitLab mirror too, so maybe it's not necessary to merge it to master.

chessai commented 4 years ago

If it's in the GitLab mirror then your MR can validate, right?

sjakobi commented 4 years ago

If it's in the GitLab mirror then your MR can validate, right?

Yep, CI is green there. If you've got a minute, could you possibly review it too? It's a base change, so core CLC territory. :)

sjakobi commented 4 years ago

FWIW, I wouldn't mind if this PR is closed. I'm just somewhat confused about the workflow of cross-submodule changes.

chessai commented 4 years ago

@sjakobi, OK, closing (which I planned to do anyway). Sorry, I know GHC's submodule usage is a bit weird.

sjakobi commented 4 years ago

Re-opening, based on the discussion in https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3388#note_291686.

sjakobi commented 4 years ago

Re-pushed since there were some CI failures.

sjakobi commented 4 years ago

Ping @chessai.

sjakobi commented 4 years ago

Cheers! :)