search

haskell / deepseq

Deep evaluation of data structures
http://hackage.haskell.org/package/deepseq
Other
40 stars 29 forks source link

deepseq-1.4.6.0 is not on Hackage #66

Closed phadej closed 2 years ago

phadej commented 3 years ago

but already bundled with GHC-9.2.0-rc1.

(Also there is no changelog entry in the repository, or even a tag, which is what I was looking for).

chessai commented 3 years ago

What is the commit GHC is using as 1.4.6.0? (I don't have time to look right now). Does it just include the change for removing Option instances as compared to 1.4.5.0? cc @bgamari

phadej commented 3 years ago

It might make sense to wait what happens with Solo in base and resolve #67 before making proper release.

phadej commented 2 years ago

GHC-9.2.1 is released, deepseq-1.4.6.0 is not on Hackage yet.

cc @chessai, @Bodigrim, @bgamari

phadej commented 2 years ago

Also:

% ghci-9.2.1
GHCi, version 9.2.1: https://www.haskell.org/ghc/  :? for help
Loaded GHCi configuration from /home/phadej/.ghci
Prelude> :m +Data.Tuple
Prelude Data.Tuple> :m +Control.DeepSeq 
Prelude Data.Tuple Control.DeepSeq> force (Solo 'x')

<interactive>:3:1: error:
    • No instance for (NFData (Solo Char))

So #67 didn't make it into the 1.4.6.0. This is unfortunate, be careful when making a release, so it's as close to the bundled version as possible.

Bodigrim commented 2 years ago

@phadej I'm not a maintainer of deepseq.

phadej commented 2 years ago

@Bodigrim you are CLC chair, and deepseq is an owner of deepseq. Maintainer or deepseq, herbert, is absent.

EDIT: actually it says:

maintainer:     libraries@haskell.org

If CLC finds a Core Library in a neglected state, it can source and install new maintainers or resolve situation by other means.

I think deepseq is in such state, so please resolve the situation.

Bodigrim commented 2 years ago

https://hackage.haskell.org/package/deepseq/maintainers/ lists @chessai as a maintainer, but I don't know whether it was a voluntary choice on his part or just one-off substituting for Herbert. If it's the latter (@chessai could you please clarify?), we should source and install a new maintainer indeed.

chessai commented 2 years ago

https://hackage.haskell.org/package/deepseq/maintainers/ lists @chessai as a maintainer, but I don't know whether it was a voluntary choice on his part or just one-off substituting for Herbert. If it's the latter (@chessai could you please clarify?), we should source and install a new maintainer indeed.

I am listed because of the lack of maintainers. I have helped with deepseq a bit in the last few months, but am far from a maintainer of it. We need to source a new maintainer(s).

mixphix commented 2 years ago

I'd be willing to take over maintainership of this package for the time being, to help push issues through that have been stagnating.

Bodigrim commented 2 years ago

@cigsender great!

Dear CLC members, I suggest we approve installing @cigsender as a new maintainer of deepseq. Please vote below. @chessai @emilypi @cgibbard @gwils

+1.

cgibbard commented 2 years ago

+1

emilypi commented 2 years ago

+1

Bodigrim commented 2 years ago

Assuming @cigsender votes for herself, we have 4 votes in favor out of 6. Assuming she abstains because of the conflict of interests, we have 3 votes in favor out of 5. Both ways the suggestion is approved.

@emilypi @chessai could you please grant @cigsender GitHub maintainer bits for this repo?

@gbaz could you please give @cigsender Hackage maintainers rights for deepseq? @cigsender what is your Hackage username?

mixphix commented 2 years ago

@Bodigrim my hackage username is melaniebrown.

chessai commented 2 years ago

Assuming @cigsender votes for herself, we have 4 votes in favor out of 6. Assuming she abstains because of the conflict of interests, we have 3 votes in favor out of 5. Both ways the suggestion is approved.

@emilypi @chessai could you please grant @cigsender GitHub maintainer bits for this repo?

@gbaz could you please give @cigsender Hackage maintainers rights for deepseq? @cigsender what is your Hackage username?

@Bodigrim and @cigsender you should have received invites to the CLC Haskell GitHub team. This will grant you access to all core libraries.

gbaz commented 2 years ago

@gbaz could you please give @cigsender Hackage maintainers rights for deepseq? @cigsender what is your Hackage username?

done. Note that because chessai is in the maintainers group, that could have been handled directly :-)

Bodigrim commented 2 years ago

Cool. We need to figure out which commit was shipped with GHC 9.2.1 and make a matching release.

mixphix commented 2 years ago

https://hackage.haskell.org/package/deepseq-1.4.6.0