search

haskell / directory

Platform-independent library for basic file system operations
https://hackage.haskell.org/package/directory
Other
58 stars 47 forks source link

Remove "install-includes: HsDirectoryConfig.h" #184

Closed mpickering closed 3 months ago

mpickering commented 3 months ago

This header file is not supposed to be installed for users, users are not supposed to use it. The file exists to be used interally (and this is explained by the "include-dirs" field in the cabal file.

It seems likely that this removal was overlooked in c87be9908023896a7f270bb076731ffba6c151b5

mpickering commented 3 months ago

This is likely to have been broken for at least 6 years anyway due to this Cabal bug - https://github.com/haskell/cabal/issues/10238

juhp commented 3 months ago

Ah, is this the cause of:

$ ghc-pkg check
Warning: include-dirs: /usr/lib64/ghc-9.6.6/lib/../lib/x86_64-linux-ghc-9.6.6/directory-1.3.8.5/include doesn't exist or isn't a directory

or is that unrelated? (also for 9.8)

I was wondering if include-dirs: . should also be removed from directory.cabal?

mpickering commented 3 months ago

Yes it is the cause of that warning @juhp, and no the include-dirs still needs to be there as the header needs to be found when building directory itself.