search

haskell / docker-haskell

MIT License
63 stars 37 forks source link

Add ghc-8.10.1 #18

Closed WillSewell closed 4 years ago

WillSewell commented 4 years ago

Resolves https://github.com/haskell/docker-haskell/issues/17.

I also made the equivalent changes as https://github.com/haskell/docker-haskell/pull/15/files#diff-6ef205b898b511431c727cb2f0ebb4de.

WillSewell commented 4 years ago

I removed the example because servant-server was not actually compatible with base-4.14 yet. I think it is sufficient to test by just installing popular packages, like cabal install aeson. What do you think?

WillSewell commented 4 years ago

@hvr what do you think of the most recent commits?

jberryman commented 4 years ago

I'd love to see this merged if it's working. Also fwiw I think it would be a nice thing if in the future a release of the compiler were coordinated with compatible releases of cabal-install, a working docker image, etc.

AlistairB commented 4 years ago

FYI a new stack version officially supporting GHC 8.10 + cabal 3.2 has been released https://github.com/commercialhaskell/stack/releases/tag/v2.3.1 . I guess it should be added back then?

psftw commented 4 years ago

I've created a new PR for GHC 8.10.1 + a number of other changes -- appreciate review if you have the time.

@WillSewell -- thanks for jumping in, and sorry about the noise (re: abandoned example code #2, lack of CONTRIBUTING.md in this repo #20 ).

WillSewell commented 4 years ago

Ok, no worries. Looks like this should be closed in favour of yours.