search

haskell / entropy

Easy entropy source for Haskell users.
Other
24 stars 49 forks source link

bump Cabal upper bound to < 3.9 #70

Closed mitchellwrosen closed 2 years ago

ysangkok commented 2 years ago

Wouldn't it be better to just remove the bound? In the optimistic case where Cabal doesn't break compat in the future, we'd avoid having to do PRs like this.

mitchellwrosen commented 2 years ago

Not if you ask me. Missing upper bounds on old versions of a library poison build plans unless a revision is made, which a library author is not likely to remember to do.

But that's probably not a debate to be had on this random ticket; I think the author/maintainer can do whatever they want with this PR.

phadej commented 2 years ago

Looks like entropy doesn't work with GHC-9.4 and windows (due toolchain change from gcc to clang). So it's possible that a release is needed (and revisions to existing releases).

phadej commented 2 years ago

Correction to previous, build failures I was seeing with GHC-9.4 came from compiling older entropy versions. Relaxing this bound seems to work https://github.com/phadej/entropy/actions/runs/2859399288 https://github.com/TomMD/entropy/compare/master...phadej:entropy:simple-ci and linking works, but also without updating bounds.

phadej commented 2 years ago

I made a revision allowing Cabal-3.8 (https://hackage.haskell.org/package/entropy-0.4.1.7/revisions/) as I was making revision for #72 anyway.

TomMD commented 2 years ago

Much appreciated!