search

haskell / fgl

A Functional Graph Library for Haskell
http://hackage.haskell.org/package/fgl
Other
185 stars 54 forks source link

`insEdges` not specialized #26

Closed treeowl closed 8 years ago

treeowl commented 8 years ago

Daniel Martin discovered that insEdges is not being properly specialized, and therefore the insEdge rewrite rule for Patricia trees is not firing. The fix was to mark insEdges INLINABLE. I would also recommend marking insEdge NOINLINE [0] or similar to make sure it doesn't inline prematurely and hide from the rule.

fizbin commented 8 years ago

Note that this same issue applies to insNodes, which should also be tagged INLINABLE.

ivan-m commented 8 years ago

I'll have a look at this; ta.