Added algorithms for finding strong components and cycles.

haskell / fgl

A Functional Graph Library for Haskell

http://hackage.haskell.org/package/fgl

Other

185 stars 54 forks source link

Added algorithms for finding strong components and cycles. #65

Open gablin opened 7 years ago

gablin commented 7 years ago

I've addressed all requests now, except for the one regarding bang patterns.

JeffreyBenjaminBrown commented 7 years ago

Hi! I would like to detect cycles. Is this held up for lack of tests? I could write some ...

gablin commented 7 years ago

Don't know. I thought the tests as part of the change request were sufficient, but maybe it's due to the fact that the bang patterns are missing, but I don't know how to fix that.

@ivan-m Is there anything else I need to do in order to make the pull request go through?

gablin commented 7 years ago

@ivan-m Requested changes have now been addressed.

georgefst commented 3 years ago

Any reason this never got merged? I could really do with it.

(I came here trying to work out whether the outputs of scc are guaranteed to be paths (EDIT: this can't be true in general - I'm not sure what I was getting at here), but this PR would solve my immediate problems and many more)