haskell / filepath

Haskell FilePath core library
BSD 3-Clause "New" or "Revised" License
66 stars 33 forks source link

Move internals into a separate package #192

Open hasufell opened 1 year ago

hasufell commented 1 year ago

Following:

The move could be considered a breaking change.

It's also not entirely clear what the process/impact is, since we're dealing with a boot package.

@Bodigrim @bgamari @mpickering

Bodigrim commented 1 year ago

It's also not entirely clear what the process/impact is, since we're dealing with a boot package.

One would have to add a new submodule and patch Hadrian to pick it up, but I do not expect any blockers.

jdkr commented 1 year ago

There's one question that arises to me. What would be considered as Internal? Only the modules named Internal, or the whole tree of modules located under System.OsPath and System.OsString? As far as I understand, the modules in OsPath are the implementation of the Abstract File Path Proposal (which may change in the future) and the modules in OsString are platform specific. Both I would consider Internal.

hasufell commented 11 months ago

https://github.com/haskell/filepath/pull/200