search

haskell / filepath

Haskell FilePath core library
BSD 3-Clause "New" or "Revised" License
66 stars 33 forks source link

Simplify indexWord8Array and writeWord16Array #204

Closed Bodigrim closed 7 months ago

Bodigrim commented 8 months ago

Sigh. I can conjure up CPP to support GHC < 8.6, but at that point it would no longer be a simplification.

hasufell commented 7 months ago

This will go into the new os-string. I think we also dropped ghc < 8.6 in unix, didn't we?

Bodigrim commented 7 months ago

I think we also dropped ghc < 8.6 in unix, didn't we?

According to https://github.com/haskell/unix/blob/4386d8210ce36f512436a6b522051b858b31823d/unix.cabal, yes, we did.

If you decide to drop GHC < 8.6 in os-string, I'll re-raise this PR against it. Or feel free to cherry-pick yourself, this should be good to go as is.

hasufell commented 7 months ago

If you decide to drop GHC < 8.6 in os-string

Yeah, we can do that.

hasufell commented 7 months ago

continued here: https://github.com/haskell/os-string/pull/3