search

haskell / ghc-events

Library and tool for parsing .eventlog files from GHC
http://www.haskell.org/haskellwiki/ThreadScope
Other
33 stars 33 forks source link

Fix type of ProfSampleCostCentre.profCapSet event field #108

Closed TeofilC closed 1 month ago

TeofilC commented 3 months ago

This is a CapNo rather than a CapSet. The event stores this as an Int32, but CapNo is an Int16. So we need to do some conversions.

Resolves #84

NB: this is a breaking change, as we change the type and name of this field

Mikolaj commented 3 months ago

Maybe a sentence in the changelog? It's not entirely defunct, it seems.

TeofilC commented 1 month ago

I've added a changelog entry now

Mikolaj commented 1 month ago

Merged. Thank you, @TeofilC!