haskell / ghc-events

Library and tool for parsing .eventlog files from GHC
http://www.haskell.org/haskellwiki/ThreadScope
Other
33 stars 34 forks source link

Enable Travis CI #16

Closed maoe closed 7 years ago

maoe commented 7 years ago

This PR enables Travis CI with various GHC versions including the latest one.

Mikolaj commented 7 years ago

Splendid! LGTM.

maoe commented 7 years ago

I think it's better to disable write-merge for now because otherwise we have to check every travis build log to confirm nothing is actually broken.

maoe commented 7 years ago

Travis now skips write-merge: https://travis-ci.org/maoe/ghc-events/builds/200771369

maoe commented 7 years ago

Reworded the last commit message. s/is/are/

kvelicka commented 7 years ago

Only posted an insignificant question on one of the changes. Looks good!

@Mikolaj: shall I merge it or do we want someone else's opinion as well?

Mikolaj commented 7 years ago

IMHO, if @simonmar doesn't object, let's merge. Great job, BTW.

kvelicka commented 7 years ago

Right, pending on his call then.

maoe commented 7 years ago

Any objections?

Mikolaj commented 7 years ago

I think you can safely assume there are none. :)

maoe commented 7 years ago

Okay, could we merge then?

Mikolaj commented 7 years ago

O, you didn't have repo write access. My bad, I can actually add you. Done.

maoe commented 7 years ago

Great, thank you! I'm going to merge this then.

maoe commented 7 years ago

@Mikolaj Could you please enable Travis builds? I see ghc-events on https://travis-ci.org/profile/haskell but it's grayed out so I cannot enable it.

Mikolaj commented 7 years ago

Right. Supposedly it should work now.

maoe commented 7 years ago

Thanks!

Mikolaj commented 7 years ago

You are welcome.