search

haskell / ghc-events

Library and tool for parsing .eventlog files from GHC
http://www.haskell.org/haskellwiki/ThreadScope
Other
33 stars 33 forks source link

Fix string encodings. #62

Closed bgamari closed 4 years ago

bgamari commented 4 years ago

Previously we used the Binary instance for Text to serialise the event name. This is wrong.

We now first encode to UTF-8 and use this in the eventlog encoding.

bgamari commented 4 years ago

Unfortunately testing this is quite non-trivial due to the fact that EVENT_STEAL_SPARK is translated to SparkSteal and therefore can't roundtrip.

maoe commented 4 years ago

Whoops. Apparently I wasn't careful enough when I was writing #55. The changes look good to me.

The problem is that the new test is failing due to #14. Could you disable the test until #14 is fixed?

maoe commented 4 years ago

I'll take over this PR.

maoe commented 4 years ago

Confirmed that all tests (excluding the disabled ones) passed in #65. Merging.

bgamari commented 4 years ago

Thanks @maoe!