search

haskell / ghc-events

Library and tool for parsing .eventlog files from GHC
http://www.haskell.org/haskellwiki/ThreadScope
Other
33 stars 33 forks source link

Add support for ticky ticky counts #67

Closed nineonine closed 3 years ago

nineonine commented 3 years ago

This patch add support for ticky ticky count events (which was added recently)

nineonine commented 3 years ago

cc @bgamari

maoe commented 3 years ago

Thank you for your contribution!

I'll take a closer look later but could you please add a test case that contains some ticky-ticky counts? We have a test suite which checks that ghc-events show output matches the expected output. You can find a list of example eventlogs here.

bgamari commented 3 years ago

Indeed a test would be good but this otherwise looks good to me! Thanks @nineonine.

nineonine commented 3 years ago

Thank you for your contribution!

I'll take a closer look later but could you please add a test case that contains some ticky-ticky counts? We have a test suite which checks that ghc-events show output matches the expected output. You can find a list of example eventlogs here.

For sure! I added a test.