search

haskell / ghc-events

Library and tool for parsing .eventlog files from GHC
http://www.haskell.org/haskellwiki/ThreadScope
Other
33 stars 34 forks source link

Add support for ticky definition json fields #87

Closed AndreasPK closed 1 year ago

AndreasPK commented 2 years ago

See https://gitlab.haskell.org/ghc/ghc/-/merge_requests/8514

Mikolaj commented 2 years ago

Oh, so that's why eventlog2html was crashing for me when I tried to feed it HEAD's evenlog from ticky? Thanks a lot for the PR!

AndreasPK commented 2 years ago

Oh, so that's why eventlog2html was crashing for me when I tried to feed it HEAD's evenlog from ticky? Thanks a lot for the PR!

Matt at least thinks it's because https://github.com/haskell/ghc-events/pull/83 hasn't been merged yet.

AndreasPK commented 1 year ago

@maoe Let me know if anything more is required to get this merged.

AndreasPK commented 1 year ago

Rebased on https://github.com/haskell/ghc-events/pull/83.

maoe commented 1 year ago

Thanks I'll take a look in a few days.

maoe commented 1 year ago

LGTM. Thanks!