search

haskell / ghcup-metadata

GHCup metadata repository
33 stars 30 forks source link

Add metadata on release of Stack 3.1.1 #241

Closed mpilgrem closed 3 months ago

mpilgrem commented 3 months ago

I am not sure how 'Recommended' is meant to work for the vanilla channel - it that the GHCup project's decision or is it the origin's decision? From the perspective of the Stack project, the latest released version of Stack is always recommended.

hasufell commented 3 months ago

I am not sure how 'Recommended' is meant to work for the vanilla channel - it that the GHCup project's decision or is it the origin's decision?

So far the policy was recommended == latest, but I'm fine with upstream doing the decisions.

andreasabel commented 3 months ago

Merging is blocked The base branch requires all commits to be signed.

@mpilgrem Do you intend to replace the commit by a signed one?

mpilgrem commented 3 months ago

@andreasabel, can you give me a pointer to what I would have to do to make a 'signed' commit? EDIT: Scratch that request, I see GitHub has an article on the subject.

hasufell commented 3 months ago

@mpilgrem the files themselves have to be signed with gpg too and a separate .sig file committeed, also see https://github.com/haskell/ghcup-metadata?tab=readme-ov-file#gpg-signing

mpilgrem commented 3 months ago

@hasufell, sorry if I merged prematurely, on that basis. EDIT: I see that a GHCup developer will need to sign the files that I edited.

hasufell commented 3 months ago

@hasufell, sorry if I merged prematurely, on that basis. EDIT: I see that a GHCup developer will need to sign the files that I edited.

merging to develop is fine if it's not signed. But master has to work with ghcup --gpg Strict -s https://raw.githubusercontent.com/haskell/ghcup-metadata/master/ghcup-vanilla-0.0.8.yaml list.

I fixed it.