haskell / hackage-security

Hackage security framework based on TUF (The Update Framework)
http://hackage.haskell.org/package/hackage-security
56 stars 47 forks source link

Make incremental update of uncompressed index.tar more robust #197

Closed hvr closed 6 years ago

hvr commented 6 years ago

There's a another variant (see #198) of this I'd like to try (& benchmark) later today which would address #196 in a more principled way.

edsko commented 6 years ago

Sounds good to me. As discussed, perhaps the arbitrary "last 512 kB" heuristic can even be replaced by checking the entire file (since we probably don't need to write it); overhead of that over the unzipping is probably minimal and we'd catch all problems then.

hvr commented 6 years ago

closing this one in favor of #198