haskell / hackage-security

Hackage security framework based on TUF (The Update Framework)
http://hackage.haskell.org/package/hackage-security
56 stars 48 forks source link

Update hackage-security to GHC 8.8 #234

Closed Avi-D-coder closed 4 years ago

Avi-D-coder commented 4 years ago

This goes on top of #232

Avi-D-coder commented 4 years ago

Is MonadFail the right approach?

hvr commented 4 years ago

@Avi-D-coder to be honest, I'm utterly confused by this PR; is this really against master? Also this seems to address an issue that has long been resolved by 471a7b8ec1867cc4b641b7846912252e74637b87, no?

bgamari commented 4 years ago

Hmm, indeed I am also a bit confused; master already appears to build with GHC 8.8.1. @Avi-D-coder, is there a particular error that you were seeing?

Avi-D-coder commented 4 years ago

This was based on #232