search

haskell / hackage-security

Hackage security framework based on TUF (The Update Framework)
http://hackage.haskell.org/package/hackage-security
56 stars 48 forks source link

Remove the >= 8.2 workaround once Cabal > 3.8.1.0 is released #282

Closed Mikolaj closed 6 months ago

Mikolaj commented 2 years ago

The && impl(ghc >= 8.2) workaround can then be removed, because the underlying problem is fixed on master and 3.8 branch. Actually, it's also worked around as a Cabal-syntax revision on Hackage (https://github.com/haskell/cabal/issues/8371), but I guess it's safer to wait for the permanent fix.

juhp commented 2 years ago

(Btw/tangentially cabal-install-3.6.2.0 fails to build when hackage-security pulls in Cabal-syntax-3.8)

Mikolaj commented 2 years ago

@juhp: isn't this fixed in hackage-security 0.6.2.2?

Mikolaj commented 2 years ago

Huh, it probably isn't --- I only fixed this for very old GHCs and for the hackage-security test suite itself. I'm afraid that's a case of https://github.com/haskell/cabal/issues/8370 and it can be worked around similarly as for hackage-security test suite in https://github.com/haskell/hackage-security/pull/281.

That would be embarrassing. We'd need to fix old versions of cabal due to regressions in a new version.

Mikolaj commented 2 years ago

Unless somebody has a fix for https://github.com/haskell/cabal/issues/8370 and/or hackage-security.

andreasabel commented 6 months ago

We dropped GHC 8.2, so I guess this is resolved.