haskell / hackage-security

Hackage security framework based on TUF (The Update Framework)
http://hackage.haskell.org/package/hackage-security
56 stars 48 forks source link

Bump Cabal and Cabal-syntax to allow 3.14 #319

Closed fgaz closed 1 month ago

fgaz commented 1 month ago

I have tested the change by running cabal build all && cabal test all with the following cabal.project.local:

packages: /path-to-cabal-repo/Cabal
packages: /path-to-cabal-repo/Cabal-syntax
constraints: Cabal==3.14.*
constraints: Cabal-syntax==3.14.*

where /path-to-cabal-repo is my local checkout of cabal 3.14

Mikolaj commented 1 month ago

Merging. @fgaz: thanks a lot!

fgaz commented 1 month ago

Now we need this on hackage. Looking at the diff between master and the last version, we just need a revision

https://github.com/haskell/hackage-security/compare/hackage-security/v0.6.2.6...master

Mikolaj commented 1 month ago

Oh, well spotted. Any objections to revising? If not, and if nobody does, I will soon.

@andreasabel: I remember you have a bespoke system for noting down the revision in the actual cabal files. Shall I try to emulate this while I revise or just leave it to you?

Mikolaj commented 1 month ago

For now, I've just made the revision: https://hackage.haskell.org/package/hackage-security-0.6.2.6/revisions/

andreasabel commented 1 month ago

I guess x-revision: 3 in hackage-security.cabal is now outdated: https://github.com/haskell/hackage-security/pull/319/files#diff-e4f51efc4a32ec2324f64ef4e50bfbd56a48f987f31234374a908827aa4a8851L4

Should probably be bumped to 4 (or deleted if you do not want to maintain this field).

Mikolaj commented 1 month ago

Oh, so it's so simple. Fixed (updated). Thank you.