haskell / hackage-server

Hackage-Server: A Haskell Package Repository
http://hackage.haskell.org
Other
417 stars 199 forks source link

Fixing the inconsistent rendering of haddocks across hackage #1349

Open MangoIV opened 23 hours ago

MangoIV commented 23 hours ago

I think I have a pretty "simple" idea for a fix here. How about we

That way we wouldn't get outdated styles.

MangoIV commented 22 hours ago

So afaiu at the moment, how it works is that hackage-server just loads the tarball and then serves whatever file from the tarball that was requested. I guess to replace the css then, whenever we match on a css path, we would serve our own css :3.

https://github.com/haskell/hackage-server/blob/962b6d77c54e4cb2491c7be3fe84797c60471782/src/Distribution/Server/Features/Documentation.hs#L296-L298

Also, it appears hackage-server already does something like this: https://github.com/haskell/hackage-server/blob/962b6d77c54e4cb2491c7be3fe84797c60471782/src/Distribution/Server/Features/Documentation.hs#L300C1-L304

ulysses4ever commented 22 hours ago

I agree it's annoying to have to look at the outdated haddock styles. I wondered if it's possible to do something along the proposed lines.

OTOH, it won't be easy to build a consensus behind what appears to be a rather drastic measure -- to override the contents of user-generated archives...

MangoIV commented 22 hours ago

In my opinion user generated archives shouldn't be a thing at all. I think it would be even be a good idea to throw away everything that isn't enclosed in the html type and then some tags that may be dangerous. (like Githubissues.

  • Githubissues is a development platform for aggregating issues.