As part of the ghc-9.0 branch, a fix was introduced to keep the ignore-exports option working, but this fix was mistakenly dropped in later branches. Furthermore, the test introduced in #1082 to prevent regressions was also broken at a later point. This PR reintroduces the fix, fixes the old HTML test, and introduces a new hoogle test.
This PR targets 9.4; #1532 is a similar PR for 9.2. I don't know, however, how to ensure that this fixes also lands on main (or ghc-head?), and how to prevent the tests from just being ignored or "fixed" in the future.
Implementation
The fullModuleContents function iterates on all declarations of the module, but only keeps declarations for which it finds an AvailInfo, obtained from GHC's type-checker's output (see tcg_exports). However, that list only contains the AvailInfo information for declarations that are exported out of the module. To prevent non-exported declarations from being ignored when we actually request them, this PR takes the same approach as b93c6351afdfaf452ad9830a5f8536a353320a84 and crafts a simple AvailInfo for each declaration to be used in lieu of the raw tcg_exports list.
Steps to verify
See #1531 for a repro case.
Caveats
This PR bumps the dependency version of haddock-api to 2.27.1, as that is the version in that branch; without that, this branch doesn't compile.
Description
As part of the
ghc-9.0branch, a fix was introduced to keep theignore-exportsoption working, but this fix was mistakenly dropped in later branches. Furthermore, the test introduced in #1082 to prevent regressions was also broken at a later point. This PR reintroduces the fix, fixes the old HTML test, and introduces a new hoogle test.This PR targets 9.4; #1532 is a similar PR for 9.2. I don't know, however, how to ensure that this fixes also lands on
main(orghc-head?), and how to prevent the tests from just being ignored or "fixed" in the future.Implementation
The
fullModuleContentsfunction iterates on all declarations of the module, but only keeps declarations for which it finds anAvailInfo, obtained from GHC's type-checker's output (seetcg_exports). However, that list only contains theAvailInfoinformation for declarations that are exported out of the module. To prevent non-exported declarations from being ignored when we actually request them, this PR takes the same approach as b93c6351afdfaf452ad9830a5f8536a353320a84 and crafts a simpleAvailInfofor each declaration to be used in lieu of the rawtcg_exportslist.Steps to verify
See #1531 for a repro case.
Caveats
This PR bumps the dependency version of
haddock-apito 2.27.1, as that is the version in that branch; without that, this branch doesn't compile.