haskell / happy

The Happy parser generator for Haskell
Other
276 stars 85 forks source link

Release? #204

Closed Ericson2314 closed 2 years ago

Ericson2314 commented 2 years ago

Should we do a release before the package splitting? (The least easy release, hah!)

I thought this was discussed, but I cannot find.

CC @int-index

int-index commented 2 years ago

I haven’t followed closely, so I don’t know what the difference would be with the last release (1.20.0). If there are features that users are waiting for, then sure, no reason to hold back.

Ericson2314 commented 2 years ago

I checked, I think the big feature is the bootstrapping. I think the dirt-simple single-package no-bootstrap-happy needed position we're at might be worth releasing before we trade one sort of complexity for another.

I think we were holding off because you were thinking of replacing your tuned custom parser combinators with the slower ones in base for brevity, but I don't mind not doing that until later. (Insofar that I don't believe the standard library should have an arbitrary take on parser combinators, this is more "portable" anyways.)

int-index commented 2 years ago

Yep, it’s a trade-off between familiarity/perf. I’m not in a hurry to get rid of the ones I’ve implemented.

Ericson2314 commented 2 years ago

Opened #206. If you are in no hurry, that sways it for me; release is probably a good idea.

Ericson2314 commented 2 years ago

I merged the read me change and uploaded a release candidate https://hackage.haskell.org/package/happy-1.21.0/candidate

Ericson2314 commented 2 years ago

https://hackage.haskell.org/package/happy-1.21.0 it's out.