search

haskell / happy

The Happy parser generator for Haskell
Other
276 stars 85 forks source link

Create Tabular package #209

Closed knothed closed 2 years ago

knothed commented 2 years ago

Create a Tabular package which contains the Tabular module and related stuff like LALR.

knothed commented 2 years ago

When this MR is merged, #200 would be obsolete.

@Ericson2314 @int-index I believe the one thing left here is renaming, and possibly moving, Lr1State. Any suggestions?

Ericson2314 commented 2 years ago

ARRAY-NOTES has some grammar things too, maybe we should split it for now?

knothed commented 2 years ago

ARRAY-NOTES has some grammar things too, maybe we should split it for now?

Hmm I'd probably prefer documenting this somewhere in the code. Grammar.lhs already has parts of the ARRAY-NOTES as a comment - what do you think?

Ericson2314 commented 2 years ago

@knothed That's better! Then I'd say leave where it was in this commit, and then convert to code comments in subsequent commit.

knothed commented 2 years ago

Could this be merged? I think we won't need #200 anymore after merging this.

Ericson2314 commented 2 years ago

Oh sorry I lost track of this. I am fine with Lrt1State for now, and I think I am fine with the rest of this too. @int-index you have any thoughts?

Ericson2314 commented 2 years ago

200 I rebased to just be additional splits and the main part, so I am happy to keep it around for later for when we revisit that sort of stuff :)

int-index commented 2 years ago

I will review by Monday.

int-index commented 2 years ago

I have not reviewed by Monday. Shame on me. But I’m doing it right now.

int-index commented 2 years ago

LGTM. Thank you!