Closed knothed closed 2 years ago
When this MR is merged, #200 would be obsolete.
@Ericson2314 @int-index I believe the one thing left here is renaming, and possibly moving, Lr1State
. Any suggestions?
ARRAY-NOTES
has some grammar things too, maybe we should split it for now?
ARRAY-NOTES
has some grammar things too, maybe we should split it for now?
Hmm I'd probably prefer documenting this somewhere in the code. Grammar.lhs
already has parts of the ARRAY-NOTES as a comment - what do you think?
@knothed That's better! Then I'd say leave where it was in this commit, and then convert to code comments in subsequent commit.
Could this be merged? I think we won't need #200 anymore after merging this.
Oh sorry I lost track of this. I am fine with Lrt1State
for now, and I think I am fine with the rest of this too. @int-index you have any thoughts?
I will review by Monday.
I have not reviewed by Monday. Shame on me. But I’m doing it right now.
LGTM. Thank you!
Create a Tabular package which contains the
Tabular
module and related stuff like LALR.