search

haskell / haskeline

A Haskell library for line input in command-line programs.
https://hackage.haskell.org/package/haskeline
BSD 3-Clause "New" or "Revised" License
221 stars 75 forks source link

Fix GHC HEAD Warnings #1

Closed hvr closed 10 years ago

hvr commented 10 years ago

This is mostly a reminder for me to send a fix later today

libraries/haskeline/System/Console/Haskeline/Monads.hs:73:10: Warning:
    ‛StateT’ is an instance of Monad but not Applicative - this will become an error in GHC 7.10, under the Applicative-Monad Proposal.

libraries/haskeline/System/Console/Haskeline/Term.hs:107:16: Warning:
    In the use of ‛isEmptyChan’
    (imported from Control.Concurrent, but defined in Control.Concurrent.Chan):
    Deprecated: "if you need this operation, use Control.Concurrent.STM.TChan instead.  See http://hackage.haskell.org/trac/ghc/ticket/4154 for details"

libraries/haskeline/System/Console/Haskeline/Backend/DumbTerm.hs:24:27: Warning:
    ‛DumbTerm’ is an instance of Monad but not Applicative - this will become an error in GHC 7.10, under the Applicative-Monad Proposal.

libraries/haskeline/System/Console/Haskeline/Backend/Terminfo.hs:106:15: Warning:
    ‛Draw’ is an instance of Monad but not Applicative - this will become an error in GHC 7.10, under the Applicative-Monad Proposal.
hvr commented 10 years ago

PR #2 fixes all warnings except the isEmptyChan-warning

hvr commented 10 years ago

as the GHC HEAD specific warnings have been fixed, this issue is essentially resolved; the isEmptyChan issue occurs with other GHC 7.x as well, and is therefore not GHC HEAD specific.