haskell / haskeline

A Haskell library for line input in command-line programs.
https://hackage.haskell.org/package/haskeline
BSD 3-Clause "New" or "Revised" License
223 stars 75 forks source link

Lower cabal requirement to 1.10 #17

Closed letmaik closed 9 years ago

letmaik commented 9 years ago

Between haskeline 0.7.1.0 and 0.7.1.2 you raised the required cabal version from 1.8 to 1.16, which by the way would totally require at least a minor version bump. Seeing that you only used the default-* features it would be enough to require cabal 1.10, since this is when that feature was introduced. The reason I ask for that is of course compatibility. Currently, a travis build of mine unnecessarily fails due to this: https://travis-ci.org/neothemachine/scion-class-browser/jobs/46119820 Lowering the bound makes it work: https://travis-ci.org/neothemachine/haskeline/jobs/46123976 It would be nice if the cabal bound could be lowered, at least to 1.14 in case you don't want to go down to 1.10. Thanks!

hvr commented 9 years ago

The Cabal user guide could be a bit more clear about it; there's actually little benefit in specifying anything in between of cabal-version: >=1.10 and cabal-version: >=1.21 as of Cabal-1.22, as no (significant) features were added between Cabal 1.10 and 1.22...

TLDR: haskeline should simply use cabal-version: >=1.10

hvr commented 9 years ago

just noticed there's the #15 PR to address this

letmaik commented 9 years ago

Whoops, good to know. Now we just need to wait...

judah commented 9 years ago

Done in haskeline-7.2.0.