search

haskell / haskeline

A Haskell library for line input in command-line programs.
https://hackage.haskell.org/package/haskeline
BSD 3-Clause "New" or "Revised" License
221 stars 75 forks source link

Add missing Functor/Applicative instances (re #1) #2

Closed hvr closed 10 years ago

hvr commented 10 years ago

This is needed to silence GHC 7.8's AMP warnings, see also

http://www.haskell.org/haskellwiki/Functor-Applicative-Monad_Proposal#Missing_superclasses

for more information.

Signed-off-by: Herbert Valerio Riedel hvr@gnu.org

hvr commented 10 years ago

note, as this adds new instances, a minor or even a major version bump might be in order, depending on how the PVP is intepreted (imho, adding non-orphaned instances should only require a minor bump, but it's debatable)

judah commented 10 years ago

Happily, all of the monads you've updated are internal to Haskeline, so this won't need a version bump. (The only monadic part of the API is InputT, which is already an instance of Applicative.)