haskell / haskeline

A Haskell library for line input in command-line programs.
https://hackage.haskell.org/package/haskeline
BSD 3-Clause "New" or "Revised" License
223 stars 75 forks source link

upstream the win32 console text support to GHC #47

Closed jmn closed 5 years ago

jmn commented 7 years ago

There's a bunch of issues on GHC's Trac regarding hPutChar crashing on Win32 - which seems to have been solved in Haskeline. Is there any possibility of upstreaming the code in Haskeline to GHC?

judah commented 7 years ago

Can you post a link to those GHC issues? I did a quick search but wasn't sure which one(s) you were referring to.

jmn commented 7 years ago
DemiMarie commented 7 years ago

The reason these are not issues in Haskeline is because it uses WriteConsoleW, which is the only correct way to write to a Windows console.

judah commented 5 years ago

Closing since, as mentioned above, these issues don't appear to be related specifically to Haskeline, and/or appear to be fixed upstream; e.g. ghc: https://ghc.haskell.org/trac/ghc/ticket/4471#comment:29