Test suite didn't catch the lose of code actions in vscode with haskell-lsp-0.16

haskell / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE

BSD 3-Clause "New" or "Revised" License

2.38k stars 211 forks source link

Open jneira opened 5 years ago

jneira commented 5 years ago

Unfortunately, the test suite didn't catch the bug that caused the lose of code actions (quick fixes, etc) in vscode when hie started to use haskell-lsp-0.16: https://github.com/haskell/haskell-ide-engine/pull/1402
The bug is already corrected with https://github.com/haskell/haskell-ide-engine/pull/1418 (really a quick fix!)
@mpickering mentioned that maybe lsp-test doesn't respect the capabilities advertised by the server and sends the requests anyway

lukel97 commented 4 years ago

For reference, this is probably the related change in haskell-lsp https://github.com/alanz/haskell-lsp/pull/192/files