search

haskell / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE
BSD 3-Clause "New" or "Revised" License
2.38k stars 211 forks source link

Add 8.8.2 stack file and CI #1607

Closed lukel97 closed 4 years ago

Avi-D-coder commented 4 years ago

@jneira is 8.8.2 working on windows?

lukel97 commented 4 years ago

Actually, is Azure CI missing?

I'm not familiar with the Azure stuff, can you or @jneira handle this afterwards?

jneira commented 4 years ago

@Avi-D-coder last time i tried with cabal i hit a compilation error involving haddock-api but i'll try again The pr already has a workaround

jneira commented 4 years ago

Lot of test errors with ghc-8.2.2, are they present in local tests?

jneira commented 4 years ago

Trying with cabal after adding

source-repository-package
    type: git
    location: https://github.com/haskell/haddock.git
    subdir: haddock-api
    tag: be8b02c4e3cffe7d45b3dad0a0f071d35a274d65

in cabal.project

jneira commented 4 years ago

I am getting this compile error in windows using stack:

ormolu               > D:\sr\snapshots\f5723ebd\lib\x86_64-windows-ghc-8.8.2\ghc-lib-parser-8.8.2-75ZOMeqOpqa23xhx9rJVRy\HSghc-lib-parser-8.8.2-75ZOMeqOpqa23xhx9rJVRy.o: unhandled PEi386 relocation type 0
ormolu               > ghc.exe: unable to load package `ghc-lib-parser-8.8.2'
......
--  While building package ormolu-0.0.3.1 using:
      D:\sr\setup-exe-cache\x86_64-windows\Cabal-simple_Z6RU0evB_3.0.1.0_ghc-8.8.2.exe --builddir=.stack-work\dist\29cc6475 build --ghc-options ""
    Process exited with code: ExitFailure 1

I've added ghc-8.8.2 to azure anyway

jneira commented 4 years ago

The fix for windows to be able to build Cabal was not included in ghc-8.8.2, it has been backported to 8.8.3 :sob:

I am getting the same error for windows building it with cabal than ghc-8.8.1:

ghc.exe: unable to load package `Cabal-3.0.1.0'
ghc.exe:  | D:\Trabajo\NO-SALVAR\jneira\bin\Programs\stack\x86_64-windows\ghc-8.8.2\lib\Cabal-3.0.1.0\HSCabal-3.0.1.0.o: unknown symbol `.file'
cabal.exe: Failed to build lib:c-h-internal from cabal-helper-1.0.0.0 (which
is required by test:wrapper-test from haskell-ide-engine-1.0.0.0,
test:unit-test from haskell-ide-engine-1.0.0.0 and others). See the build log
above for details.

So i have to remove this version from windows too :disappointed:

lukel97 commented 4 years ago

The linux CircleCI tests were failing because I forgot to update the testutils with the new version, committing that fix now

The fix for windows to be able to build Cabal was not included in ghc-8.8.2, it has been backported to 8.8.3 😭

Argh, c'est la vie.