search

haskell / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE
BSD 3-Clause "New" or "Revised" License
2.38k stars 211 forks source link

Put IdeResult in terms of Either, add ideError #1611

Open Gurkenglas opened 4 years ago

Gurkenglas commented 4 years ago

Let's try this again.

Avi-D-coder commented 4 years ago

@Gurkenglas What is the motive for this change? It is allot more concise.

Gurkenglas commented 4 years ago

You have answered your question :3

jneira commented 4 years ago

Thanks for the pr, i think the intent is good and i always like the prs that remove locs (the actual new type has its own advantages though). However, as you surely already knows, we just have start a process of integration with ghcide so it is the actual main focus. We will continue to fix bugs but we will prefer that the new code or internal refactorings go in that direction (see https://github.com/haskell/haskell-ide-engine/issues/1416#issuecomment-579010923).