Use sha instead revision for hsimport and other fixes

haskell / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE

BSD 3-Clause "New" or "Revised" License

2.38k stars 212 forks source link

Use sha instead revision for hsimport and other fixes #1694

Closed jneira closed 4 years ago

jneira commented 4 years ago

@revn way to specify a revision in stack.yaml files seems to be not reliable: it is using the package version without the revision under some circumstances. It is possible that wipping out the entire $STACK_ROOT could fix it but is is not desirable
we have tested that using pantry sha seems to make stack use the patched version, although it is somewhat ugly
closes #1689

jneira commented 4 years ago

There is a unit test failing due to the version bump to 1.2, weird that it was not triggered before :thinking:

jneira commented 4 years ago

Fixed unit test with f6ba5ed (cc @gdziadkiewicz )

gdziadkiewicz commented 4 years ago

Sorry for the problem :( and thanks for the cc, I appreciate the opportunity to learn how to do things better :)

jneira commented 4 years ago

@gdziadkiewicz dont worry, your contributions have been great and that is a minor detail, only want to show you just in case you have not used the Paths_* magic module before.

jneira commented 4 years ago

The macos-installhs-cabal azure job failed cause brew installs ghc-8.8.3 by default but we dont support it yet and there is no stack-8.8.3.yaml

fendor commented 4 years ago

Nice catch, @jneira!

infinisil commented 4 years ago

Oh! I'm pretty sure that the problem here was that @rev1 is the wrong syntax, it should be @rev:1, as documented here.

I looked at the pantry source code (which is what parses these fields), and it seems to just use the latest revision for @rev1 (aka it couldn't parse it): https://github.com/commercialhaskell/pantry/blob/603fea5f4cb812b08edc74cd9e1178fa76309f55/src/Pantry/Types.hs#L769-L785

There's another instance of this in master, introduced in 0bdf8ccd9cfffff74bb2d3eb1950856ee1abed02. I'll make a PR to fix this (-> https://github.com/haskell/haskell-ide-engine/pull/1770)