search

haskell / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE
BSD 3-Clause "New" or "Revised" License
2.38k stars 213 forks source link

Make install script use unix-time-0.4.7 #1715

Closed jneira closed 4 years ago

jneira commented 4 years ago
mouse07410 commented 4 years ago

@jneira is there a reason why you're using resolver 13.19, rather than 15.6 or at least 14.27?

FWIW, I seem to be able to build the master branch successfully using resolver 15.6 in install/shake.yaml.

jneira commented 4 years ago

No other than match the most used resolver/ghc to try download only one ghc and keep one stack cache. The "most used" ghc is not exact but, f.e. in windows ghc-8.8.* still has bugs and ghc-8.10 is not supported yet.

mouse07410 commented 4 years ago

@jneira I'm confused.

On one hand, HIE must be built by the same GHC that it would serve, or there could/would be problems.

On the other hand, you're freezing install/shake.yaml at the older GHC-8.6.5 LTS resolver - and not even the current GHC-8.6.5 LTS resolver (which is 14.27).

I can understand why not lts-15.6. But why not lts-14.27?

And how does it (or why it doesn't) impact building HIE with/for GHC-8.8.3 (e.g., on Mac and Linux)?

And yeah, I understand about 8.10.1. :-(

jneira commented 4 years ago

I think maybe it is a little bit clear in https://github.com/haskell/haskell-ide-engine/issues/1712#issuecomment-608238790

But yeah, it could use the last lts for each ghc version. At the end it is a (relatively small) script and it works so we did no take care of so much.

mouse07410 commented 4 years ago

@jneira I hear you, thanks.

I'd still suggest bringing the resolver to lts-14.27 if you intend this script to stay with GHC-8.6.5, or to lts-15.6 if you're to move to GHC-8.8.3.