search

haskell / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE
BSD 3-Clause "New" or "Revised" License
2.38k stars 211 forks source link

Use default config on missing configuration section #1802

Closed aufarg closed 3 years ago

aufarg commented 4 years ago

Use default config on missing configuration section

On serving initialize request, the deserialization of HIE configuration embedded in InitializeParam passed by client will result in an error if during the deserialization process the server cannot find HIE specific configuration key under initializationOptions.

This commit changes the initializationOptions deserialization to return the default configuration if configuration key cannot be found under initializationOptions. Here, setting the key with a value of null will also be considered as part of not found condition to accommodate clients that fills missing user options as null.

alanz commented 3 years ago

@aufarg This project is not actually active any more, so PRs will not be merged. I see you did do something on haskell-language-server too, which is the project superseding this one

aufarg commented 3 years ago

@alanz Okay, I'll close the PR then. Thanks for telling me this.