search

haskell / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE
BSD 3-Clause "New" or "Revised" License
2.38k stars 211 forks source link

Tests depend on 'liquid' binary #899

Closed jhrcek closed 6 years ago

jhrcek commented 6 years ago

When you run make test at the root of the project BUT you don't have liquid binary on your PATH, the tests will fail with pattern match failure here. But there are no instructions on how to set up liquid anywhere in the repo. I think the tests could point user to what's wrong (e.g. pattern match Nothing -> error "these tests requireliquidbinary to run") and the repo should provide the instructions about how to set that up. I can work on this, but could use some help (see https://github.com/haskell/haskell-ide-engine/pull/898)

alanz commented 6 years ago

I agree the readme needs to be updated. The liquid binary comes from installing the liquidhaskell package, and the one I use, and is reported by cabal list liquidhaskell, is 0.8.2.4

jhrcek commented 6 years ago

Resolved by adding comment to doc/Hacking.md in https://github.com/haskell/haskell-ide-engine/pull/898 and also there's been test added which checks that liquid binary is present in https://github.com/haskell/haskell-ide-engine/pull/900 which makes the reason for failures without liquid clearer.