search

haskell / haskell-language-server

Official haskell ide support via language server (LSP). Successor of ghcide & haskell-ide-engine.
Apache License 2.0
2.66k stars 355 forks source link

Consistent GHC ABI checking #2720

Open hasufell opened 2 years ago

hasufell commented 2 years ago

Currently we do ABI checking here:

https://github.com/haskell/haskell-language-server/blob/f1e146b5a6409106d89241581d4f3ab755481e2d/bindist/wrapper.in#L65-L81

@wz1000 suggested this should maybe be done in haskell-language-server-wrapper binary directly. But @fendor noted that the logic to get GHC is actually in hie-bios and this PR is relevant: https://github.com/haskell/hie-bios/pull/282

So we probably want to check ABI in/via hie-bios.

Background:

pepeiborra commented 2 years ago

Now that hie-bios 0.9.0 is out, has anything changed re ABI checking?

hasufell commented 2 years ago

No. We still do abi checking in the shell script only.