haskell / haskell-language-server

Official haskell ide support via language server (LSP). Successor of ghcide & haskell-ide-engine.
Apache License 2.0
2.61k stars 351 forks source link

Unify critical session running in hls #4251

Closed soulomoon closed 1 week ago

soulomoon commented 1 month ago

There are some places we serialize critical session.

The latter two create a challenge for our shutdown handler to halt the hls. Since they are not cancelable. A possible solution, would be to switch the latter two to the first approach. Create a thread specifically to run the target critical session.

soulomoon commented 1 month ago

This might fix the hanging problem happend in windows https://github.com/haskell/haskell-language-server/pull/2497

michaelpj commented 1 week ago

We did this