haskell / haskell-language-server

Official haskell ide support via language server (LSP). Successor of ghcide & haskell-ide-engine.
Apache License 2.0
2.61k stars 351 forks source link

Fix CradleTests "simple-multi-def-test" test #4262

Open soulomoon opened 1 month ago

soulomoon commented 1 month ago

In previous migrate of CradleTests, removal of withLongTimeout seems to be causing trouble to windows expecially when the load is high. Add it back fix that.

michaelpj commented 1 month ago

Please add a comment explaining why it's there for future people!

soulomoon commented 1 month ago

Yeah, I'll continue this if there is more timeout can be observed in the CI

soulomoon commented 1 month ago

I've done some tests and I am not sure if it is just a timeout problem. This test is fairly broken in windows. I've created an issue for this. https://github.com/haskell/haskell-language-server/issues/4270