haskell / haskell-language-server

Official haskell ide support via language server (LSP). Successor of ghcide & haskell-ide-engine.
Apache License 2.0
2.65k stars 355 forks source link

Prepare release 2.9.0.0 #4319

Closed fendor closed 3 months ago

fendor commented 3 months ago

Releasing

Release checklist

michaelpj commented 3 months ago

I think we should at least wait for https://github.com/haskell/haskell-language-server/pull/4314 and re-enable the fourmolu plugin.

fendor commented 3 months ago

@michaelpj Ok, that's fine by me. If we wait, we can also include #4318. I am just making sure, we are not further bogged down by CI issues.

michaelpj commented 3 months ago

Remember to update the support tables in the docs (that should be in the checklist!)

fendor commented 3 months ago

It is in the checklist, just the fourth to last item, which is clearly too late :) Moved it up in the checklist.

fendor commented 3 months ago

Done, updated the supported GHC version table

michaelpj commented 3 months ago

Uh... I should have actually read the checklist before commenting :sweat_smile:

michaelpj commented 3 months ago

I removed the remaining unnecesssary cabal.project bits

michaelpj commented 3 months ago

Reverted sorry, I was doing it wrong

benz0li commented 3 months ago

ℹ️ One has to patch https://github.com/haskell/haskell-language-server/blob/287ee42ab566e5c088d80ec859d991f5be04f66e/GNUmakefile#L141 when using cabal-install versions ≥ 3.11 (i.e. cabal-install-v3.12.0.0-prerelease).
👉 Patch: Modify "$(STORE_DIR)/ghc-$(GHC_VERSION)" to "$(STORE_DIR)/ghc-$(GHC_VERSION)-inplace".

Cross reference: