Closed fendor closed 3 months ago
I think we should at least wait for https://github.com/haskell/haskell-language-server/pull/4314 and re-enable the fourmolu plugin.
@michaelpj Ok, that's fine by me. If we wait, we can also include #4318. I am just making sure, we are not further bogged down by CI issues.
Remember to update the support tables in the docs (that should be in the checklist!)
It is in the checklist, just the fourth to last item, which is clearly too late :) Moved it up in the checklist.
Done, updated the supported GHC version table
Uh... I should have actually read the checklist before commenting :sweat_smile:
I removed the remaining unnecesssary cabal.project bits
Reverted sorry, I was doing it wrong
ℹ️ One has to patch https://github.com/haskell/haskell-language-server/blob/287ee42ab566e5c088d80ec859d991f5be04f66e/GNUmakefile#L141 when using cabal-install versions ≥ 3.11 (i.e. cabal-install-v3.12.0.0-prerelease).
👉 Patch: Modify "$(STORE_DIR)/ghc-$(GHC_VERSION)"
to "$(STORE_DIR)/ghc-$(GHC_VERSION)-inplace"
.
Cross reference:
Releasing
Release checklist
.github/workflows/release.yaml
ghc: [
to find all lists.TODO:
to find locations that require extra care for GHC versions.*.cabal
files (same version as hls)hie-compat
requires no automatic version bump.shake-bench
is an internal testing tool, not exposed to the outside world. Thus, no version bump required for releases../GenChangelogs.hs <api-key> <tag>
<tag>
is the git tag you want to generate the ChangeLog from.<api-key>
is a github access key: https://github.com/settings/tokenswip/<version>
git switch -c wip/<version>
<version>
git tag <version>
git push <remote> <version>
sh scripts/release/download-gh-artifacts.sh <version> <your-gpg-email>
gh-release-artifacts/haskell-language-server-<version>/
gh-release-artifacts/haskell-language-server-<version>/
cd gh-release-artifacts/haskell-language-server-<version>
SIGNING_KEY=... ../../release/upload.sh upload
gpg --list-secret-keys --keyid-format=long
https://downloads.haskell.org/~hls/haskell-language-server-<version>/
SIGNING_KEY=... ../../release/upload.sh purge_all
to remove CDN cachesghcup-vanilla-0.0.8.yaml
andghcup-vanilla-0.0.7.yaml
sh scripts/release/create-yaml-snippet.sh <version>
to generate a snippet that can be manually inserted into the yaml filesupdateCurrently unnecessary, GHCup builds its own HLS binaries and updates that file.hls-metadata-0.0.1.json
cabal run ghcup-gen -- generate-hls-ghcs -f ghcup-0.0.7.yaml --format json --stdout
in the root of ghcup-metadata repository