search

haskell / haskell-language-server

Official haskell ide support via language server (LSP). Successor of ghcide & haskell-ide-engine.
Apache License 2.0
2.72k stars 368 forks source link

Don't show "Progress: x/y" messages until the session/cradle has been setup #752

Open lukel97 opened 4 years ago

lukel97 commented 4 years ago

Currently the progress message from haskell/ghcide#644 gets shadowed by the Shake reporting messages that say "Progress: ½", an example is in this link: https://streamable.com/nqbcfk It would probably be more clear to the user if we hold off sending the work done progress report until the session is finished setting up.

pepeiborra commented 4 years ago

Just blame Pepe Iborra 😂

pepeiborra commented 4 years ago

Jokes aside, can we inform the lsp client about the relative priorities of these progress messages, so that it will show the initialisation progress in the status bar, rather than the shake progress?

lukel97 commented 4 years ago

@pepeiborra lol, I was wondering that as well though since it would be nice to not touch the shake progress. The state machine thing is set up quite nicely, and from what I can understand multiple sessions can be set up at once so I don't want to have to do loads of bookkeeping. Alas there doesn't seem to be anything in the specification for priority

pepeiborra commented 4 years ago

What if we keep sending initialisation progress messages every 100ms or so? Will that help?

jneira commented 3 years ago

Does it continue being relevant, given changes in progress reporting since the opening of the issue?

michaelpj commented 10 months ago

I haven't seen people complaining about this, and IMO this is a client issue anyway. We should be able to have multiple open progress sessions without a problem!