Install directory option ignored on Windows

haskell / haskell-platform

Distribution of Haskell with batteries included

http://www.haskell.org/platform/

Other

381 stars 91 forks source link

Install directory option ignored on Windows #311

Open rasa opened 6 years ago

rasa commented 6 years ago

Both HaskellPlatform-8.4.3-core-x86_64-setup.exe /D=C:\haskell and HaskellPlatform-8.4.3-core-x86_64-setup.exe /S /D=C:\haskell install in C:\Program Files. If https://github.com/haskell/haskell-platform/blob/5b4d97d89789e25acd182a2620c37af679057662/hptool/os-extras/win/templates/Extralibs.nsi.mu#L90 was replaced with IfSilent it might fix the issue.

randen commented 6 years ago

For HP 8.4.3, we had to change the installer a bit for #279 which unfortunately broke the /S functionality (the changes are in PR #308). With NSIS, it is non-trivial to distinguish whether the user specified /D= or not (since the NSIS framework strips it out of the params it makes available to the client), so we never supported just the /D= functionality, but /D= used with /S is supported and will be fixed.