search

haskell / haskell-snippets

Official collection of YASnippet Haskell snippets for Emacs.
12 stars 9 forks source link

inclusion in official snippets collection? #8

Open AndreaCrotti opened 7 years ago

AndreaCrotti commented 7 years ago

Hi @LukeHoersten, would you be interested in having your snippets included in the official yasnippet collection?

Which you can find here https://github.com/AndreaCrotti/yasnippet-snippets ?

purcell commented 7 years ago

What are the trade-offs there, @AndreaCrotti ? I'm personally not a huge fan of monolithic packages like that when we have the mechanisms available to be more fine-grained about installing exactly the code users need, but I can understand the convenience argument too.

AndreaCrotti commented 7 years ago

I generally agree, however yasnippet loads snippets lazily anyway, and you will still have the same ability to change and add snippets if you like to (as long as they are reviewed). They are just a bunch of tiny files after all it's not really making that repository any heavier really.

The other advantage is that you might benefit from some other people contributions as well of course, and your snippets will reach a bigger audience..

AndreaCrotti commented 7 years ago

Before we merge them in of course (in case you agree) we just have to check for possible duplicates or do some restructuring if we need to, to make sure they are still nice and consistent, see here for the current ones: https://github.com/AndreaCrotti/yasnippet-snippets/tree/master/haskell-mode

lukehoersten commented 7 years ago

I'm certainly open to the idea. There are some snippets which depend on haskell-mode and, as you said, some overlaps. What are your thoughts on resolving these things?