haskell / hie-bios

Set up a GHC API session for various Haskell Projects
https://hackage.haskell.org/package/hie-bios
BSD 3-Clause "New" or "Revised" License
181 stars 63 forks source link

Move logging from hslogger to co-log #347

Closed michaelpj closed 2 years ago

michaelpj commented 2 years ago

This lines up with the way that logging is being done in haskell-language-server and lsp.

At the moment hie-bios is the only reason HLS has a hslogger dependency, and it means that the logs from hie-bios are inconsistent with those from the rest of the subsystems.

michaelpj commented 2 years ago

This is what the output from HLS looks like after incorporating this change. You can see that the hie-bios logs now get formatted like everything else.

Before: image

After: image

michaelpj commented 2 years ago

cc @eddiemundo

fendor commented 2 years ago

Thank you for bringing co-log to hie-bios!

michaelpj commented 2 years ago

Fixed the tests. Somehow I just didn't realise they existed :sweat_smile: I generally stopped them from issuing a step every log line, which seemed excessive, and instead just put in a couple of explicit steps.

CI is green.