Closed jneira closed 3 years ago
I have to test it locally, as ci here is using cabal.project
i tried this locally with ghc-8.8.4, removing the source-repository-package which make the build work and the build ended succesfully:
# cabal build lsp-types
..........
Completed dependent-sum-0.7.1.0 (lib)
Starting dependent-sum-template-0.1.0.3 (lib)
Building kan-extensions-5.2.3 (lib)
Building dependent-sum-template-0.1.0.3 (lib)
Installing dependent-sum-template-0.1.0.3 (lib)
Completed dependent-sum-template-0.1.0.3 (lib)
...
[51 of 51] Compiling Language.LSP.VFS ( src\Language\LSP\VFS.hs, D:\ws\haskell\haskell-lsp\dist-newstyle\build\x86_64-windows\ghc-8.8.4\lsp-types-1.3.0.0\build\Language\LSP\VFS.o )
# cat cabal.project
packages:
./lsp
./lsp-types/
./lsp-test/
package lsp
flags: +demo
tests: True
benchmarks: True
test-show-details: direct
haddock-quickjump: True
allow-newer:
lens:template-haskell,
cryptohash-sha1:base,
cryptohash-md5:base,
hslogger:base,
entropy:Cabal,
-- Required for ghc-9.0.1 support
source-repository-package
type: git
location: https://github.com/anka-213/th-extras
tag: 57a97b4df128eb7b360e8ab9c5759392de8d1659
-- https://github.com/mokus0/th-extras/pull/8
//cc @bkomuves
We should try it with hls too before making a hackage revision
hls master cant be built with this pr nor the hackage version due to duplicate definitions for length, _start and maybe someone else I am preparing a pr to make hls work on master/hackage released version, but using this did not fail at the solver phase, so I think we could merge it
Could you make a Hackage revision too?
hls master cant be built with this pr nor the hackage version due to duplicate definitions for length, _start and maybe someone else I am preparing a pr to make hls work on master/hackage released version, but using this did not fail at the solver phase, so I think we could merge it
Are you sure HLS master doesn't build? What error do you get?
Oh, thanks for noting it, the work is already done with https://github.com/haskell/haskell-language-server/pull/2059 😅