search

haskell / lsp

Haskell library for the Microsoft Language Server Protocol
366 stars 92 forks source link

On Hackage lsp-types release restricts to aeson <1.6 #373

Closed Anton-Latukha closed 2 years ago

Anton-Latukha commented 2 years ago

Seen that lsp-types was released with 2.0 support, but then the revision was made to < 1.6 https://hackage.haskell.org/package/lsp-types-1.3.0.1/revisions/.

So in the future, a new release with working support of aeson >= 2.0.1 would contribute into HLS having full support for 9.0.1.

Since brittany released support of 9.0.1 requiring aeson >= 2.0.1: https://hackage.haskell.org/package/brittany That with aeson < 1.6 here currently makes a restriction that prevents Cabal from solving bounds during HLS build for 9.0.1 with enabled brittany plugin: https://github.com/haskell/haskell-language-server/runs/4498074985?check_suite_focus=true

jneira commented 2 years ago

Thanks for noting it, we will need a new lsp release with aeson-2.0 support. Not sure if hls or its deps will need more changes though

michaelpj commented 2 years ago

I think that revision was to stop the old release from picking the new aeson, I think we just haven't done a release since we fixed it.

jneira commented 2 years ago

Not sure if hls or its deps will need more changes though

https://github.com/ennocramer/floskell/issues/68

jneira commented 2 years ago

Not sure if hls or its deps will need more changes though

https://github.com/ndmitchell/hlint/issues/1328

michaelpj commented 2 years ago

@jneira I think you're the person who can do Hackage releases. Should we go ahead and do one? I don't think there's anything we're especially waiting for.

jneira commented 2 years ago

well want to check if hls including the test suite is ok against LSP master before the release

in any case will add you to the hackage uploaders list (if you agree obviously)

is https://hackage.haskell.org/user/michaelpj you main account there?

michaelpj commented 2 years ago

Yeah, I just made a hackage account so I can help out with stuff like this :)

jneira commented 2 years ago

Yeah, I just made a hackage account so I can help out with stuff like this :)

done for the three packages living here

jneira commented 2 years ago

well want to check if hls including the test suite is ok against LSP master before the release

the aeson-2 thing is being more complex, so I will open a pr in hls only using master of LSP packages to do the sanity check before the release

michaelpj commented 2 years ago

I have a WIP branch for this, it's a fair amount of churn for dealing with the numeric type changes. Happy to keep at it, or I can push it so you can start from there.

michaelpj commented 2 years ago

https://github.com/michaelpj/haskell-language-server/tree/mpj/wip-hls-lsp-upgrade

michaelpj commented 2 years ago

Released a new version that works.