search

haskell / lsp

Haskell library for the Microsoft Language Server Protocol
364 stars 90 forks source link

Fix for #374 #376

Closed pepeiborra closed 2 years ago

pepeiborra commented 2 years ago

The problem only appears for documentChanges edits.

michaelpj commented 2 years ago

Are you going to try and tackle the fix too, or is this just to help someone else trying to do that?

pepeiborra commented 2 years ago

Plan to follow up with a fix eventually

pepeiborra commented 2 years ago

It would be a good idea to test this change against the HLS test suite before merging.

michaelpj commented 2 years ago

Good thing I have a branch getting HLS to build with the latest LSP :)

pepeiborra commented 2 years ago

It would be a good idea to test this change against the HLS test suite before merging.

Testing in https://github.com/haskell/haskell-language-server/pull/2494

pepeiborra commented 2 years ago

All tests passing now.. I found 2 completions tests in the func-test suite that were using applyEdit and broke with this bug fix. Fixed in the HLS PR.

I think we should merge this before the release