haskell / lsp

Haskell library for the Microsoft Language Server Protocol
364 stars 90 forks source link

Changelog for lsp-types-1.5 doesn't mention switch to text-rope #440

Open sjakobi opened 2 years ago

sjakobi commented 2 years ago

dhall-lsp-server is showing a build failure related to this:

src/Dhall/LSP/Handlers.hs:94:60: error:
    • Couldn't match expected type ‘Rope.Rope’
                  with actual type ‘text-rope-0.2:Data.Text.Utf16.Rope.Rope’
      NB: ‘text-rope-0.2:Data.Text.Utf16.Rope.Rope’
            is defined in ‘Data.Text.Utf16.Rope’ in package ‘text-rope-0.2’
          ‘Rope.Rope’
            is defined in ‘Data.Rope.UTF16.Internal’
                in package ‘rope-utf16-splay-0.3.2.0’
    • In the first argument of ‘Rope.toText’, namely ‘rope’
      In the first argument of ‘return’, namely ‘(Rope.toText rope)’
      In the expression: return (Rope.toText rope)
   |
94 |     Just (LSP.VirtualFile _ _ rope) -> return (Rope.toText rope)
   |                                                            ^^^^
michaelpj commented 2 years ago

We should probably not expose the constructors of VirtualFile anyway. Use virtualFileText.